Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTTP_PROXY during build + fix 2 bugs in fibers and minifer modules #113

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add HTTP_PROXY during build + fix 2 bugs in fibers and minifer modules #113

wants to merge 5 commits into from

Conversation

korenlev
Copy link

@korenlev korenlev commented Jul 30, 2018 •
edited
Loading

  1. Adds ENV and ARG for building with http_proxy configuration
  2. Fix a bug in node fibers module lookup when using node versions > 8.x
  3. Remove minify module before buildup, causing misconfigurations.
    I have no authorization to branch and add headers.
    See links to bugs details in commit.

@jshimko
Copy link
Owner

jshimko commented Jul 30, 2018

Could you please add some details in the PR description that explain what this is trying to accomplish?

@korenlev korenlev changed the title Create suggested-fixes-branch Add HTTP_PROXY during build + fix 2 bugs in fibers and minifer modules Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korenlev @jshimko