Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the IndexOufOfBoundException caused by version checker #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix the IndexOufOfBoundException caused by version checker #144

wants to merge 1 commit into from

Conversation

Lumine1909
Copy link

Fix the IndexOutOfBoundException

(SZ0(6XA8`%)SVM_4)HC(YU_tmb

@Lumine1909 Lumine1909 changed the title Fix Fix the IndexOufOfBoundException caused by version checker Nov 8, 2023
jpenilla
jpenilla requested changes Nov 8, 2023
View reviewed changes
Copy link
Owner

@jpenilla jpenilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff is unreadable due to line ending changes

@Lumine1909 @jpenilla
Fix
ea5e97e 
Fix the IndexOutOfBoundException
@jpenilla
Copy link
Owner

I've fixed up the diff, but I'm still unsure about this, in what case will GitHub return a valid JSON array that is empty? I would think the result would fail to parse at all on an error...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpenilla jpenilla jpenilla requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lumine1909 @jpenilla