feat: improving eslint config

jpapini · Jun 25, 2024 · 1460e0e · 1460e0e
1 parent 3feb076
commit 1460e0e
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 5 deletions.
diff --git a/.changeset/small-ads-try.md b/.changeset/small-ads-try.md
@@ -0,0 +1,6 @@
+---
+'@jpapini/eslint-config': minor
+'@jpapini/jest-config': minor
+---
+
+Improving ESLint config.
diff --git a/packages/eslint-config/index.js b/packages/eslint-config/index.js
@@ -21,6 +21,7 @@ const config = {
         curly: ['error', 'multi-or-nest', 'consistent'],
         // Require template literals instead of string concatenation.
         'prefer-template': 'error',
+        quotes: ['error', 'single', { avoidEscape: true, allowTemplateLiterals: false }],
 
         // Enforces `node:` prefix. (Example: `import fs from 'node:fs';`)
         'unicorn/prefer-node-protocol': 'error',
@@ -150,6 +151,11 @@ const config = {
                         format: ['camelCase'],
                         leadingUnderscore: 'require',
                     },
+                    {
+                        selector: ['interface', 'typeAlias'],
+                        format: ['PascalCase'],
+                        prefix: ['I'],
+                    },
                 ],
             },
         },

diff --git a/packages/eslint-config/react.js b/packages/eslint-config/react.js
@@ -91,6 +91,26 @@ const config = {
                 ],
             },
         },
+        {
+            files: ['**/*.tsx'],
+            rules: {
+                // Enforces naming conventions for everything across a codebase.
+                '@typescript-eslint/naming-convention': [
+                    'error',
+                    {
+                        selector: 'typeParameter',
+                        format: ['PascalCase'],
+                        prefix: ['T', 'K', 'U', 'V'],
+                    },
+                    {
+                        selector: ['method', 'parameterProperty', 'property'],
+                        modifiers: ['private'],
+                        format: ['camelCase'],
+                        leadingUnderscore: 'require',
+                    },
+                ],
+            },
+        },
     ],
 };
 

diff --git a/packages/jest-config/src/paths-to-module-name-mapper.ts b/packages/jest-config/src/paths-to-module-name-mapper.ts
@@ -1,16 +1,16 @@
 import type { Config } from '@jest/types';
 import type { CompilerOptions } from 'typescript';
 
-type TsPathMapping = Exclude<CompilerOptions['paths'], undefined>;
-type JestPathMapping = Config.InitialOptions['moduleNameMapper'];
+type ITsPathMapping = Exclude<CompilerOptions['paths'], undefined>;
+type IJestPathMapping = Config.InitialOptions['moduleNameMapper'];
 
 const escapeRegex = (str: string) => str.replace(/[-\\^$*+?.()|[\]{}]/g, '\\$&');
 
 export const pathsToModuleNameMapper = (
-    mapping: TsPathMapping,
+    mapping: ITsPathMapping,
     { prefix = '', useESM = false }: { prefix?: string; useESM?: boolean } = {},
-): JestPathMapping => {
-    const jestMap: JestPathMapping = {};
+): IJestPathMapping => {
+    const jestMap: IJestPathMapping = {};
     for (const fromPath of Object.keys(mapping)) {
         const toPaths = mapping[fromPath]!;
         if (toPaths.length === 0) continue;