You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added documentation for the auto-start feature in guided tours, explaining how tours can be set to run automatically and user options for hiding or delaying tours.
Introduced a new section on event dispatchers, detailing the events triggered when a user cancels, opts-out, or completes a tour.
Listed specific events (onBeforeTourRunSaveState, onTourRunSaveState, onAfterTourRunSaveState) and their purposes.
Changes walkthrough 📝
Relevant files
Documentation
guided-tours.md
Document auto-start and event dispatchers for guided tours
docs/general-concepts/guided-tours.md
Added section on auto-start functionality for guided tours.
Introduced event dispatchers for tour actions.
Detailed specific events triggered by user actions on tours.
Improve clarity and conciseness in the description of event dispatchers
Consider rephrasing the description of the event dispatchers to make it clearer and more concise. The current description might confuse readers with its repetitive mention of "saving the auto-start tour user state". Simplifying the language and focusing on the unique aspects of each event can improve readability and understanding.
-Those events are: -- onBeforeTourRunSaveState: triggered before saving the auto-start tour user state and recording user action logs-- onTourRunSaveState: triggered before saving the auto-start tour user state, used to record user actions into the logs-- onAfterTourRunSaveState: triggered after saving the auto-start tour user state and recording user action logs+These events are triggered at different stages:+- onBeforeTourRunSaveState: Before any data is saved or actions are logged.+- onTourRunSaveState: Just before data saving, specifically for logging actions.+- onAfterTourRunSaveState: After all data has been saved and actions logged.
Apply this suggestion
Suggestion importance[1-10]: 8
Why: The suggestion improves readability and understanding by removing repetitive language and focusing on the unique aspects of each event. This enhances the documentation's clarity, which is crucial for developers who need to understand and use these events.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Documentation
Description
onBeforeTourRunSaveState
,onTourRunSaveState
,onAfterTourRunSaveState
) and their purposes.Changes walkthrough 📝
guided-tours.md
Document auto-start and event dispatchers for guided tours
docs/general-concepts/guided-tours.md