Develop #122
Open
Develop #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADD: Check to ignore www. WHOIS servers (none start with www.) ADD: Fallback regexes, such as 'Admin .... Name', where the dots can be anything. They apply to a single field instead of a whole block. ADD: Every contacts empty fields are checked against the fall_back regexes, to see if a, for example, registrant name can still be found even if the pattern is not known. REF: 'facsimile' is now extracted as 'fax', since they mean the same thing (Fax is short for facsimile) FIX: Tabs to spaces (PEP-8)
FIX: Tabs to spaces (PEP-8) ADD: Tests ADD: Test output. Shows failed tests because of more extracted data.
…are not cached because it would be impossible to know which domains belong to which server FIX: Defaulted normalizing to False, since it seems to be broken.
… Still compatible though.
…che a persistent storage path
…limiting-prevention to develop * commit '0bc8ed5363e647577a49c8708421e3c1bef1e4b7': FIX: Package being packaged in setup.py ADD: Comments ADD: Cooldown capabilities.
REF: Setting the cache and the cool down config can be called on the pythonwhois package (__init__.py)
REF: Comments
…n now be configured
ENH: More comments REF: Extracted the building of custom CoolDownTrackers according to a config file into its own method ADD: If a WHOIS server is not found, an empty response is given.
ADD: Test for CoolDownTracker
…hen it never ends (it's mostly not my code) REF: Clarified some names ADD: A separate class for reading the config file
…success of the retrieval.
REF: Extracted the starting of a cool down to a separate method ADD: Can now check whether a rate limit has been exceeded or not FIX: If there are now results at all, parse.py simply returns an empty dictionary instead of crashing
…g-cooldown to develop * commit '4d87efe48ef7b74305e24eea944c9acb3ccb81c6': REF: Made decrement_cool_downs a little clearer REF: net.py looks a bit neater now, but I didn't go all out because then it never ends (it's mostly not my code) REF: Clarified some names ADD: A separate class for reading the config file REF: Removed threading, thanks to Wes. Thanks Wes! FIX: Order in which the cool down is decided. ADD: Test for CoolDownTracker REF: Made the name for the method that resets the cool down clearer REF: Placed CoolDownTracker into its own file ENH: More comments REF: Extracted the building of custom CoolDownTrackers according to a config file into its own method ADD: If a WHOIS server is not found, an empty response is given. FIX: Clarification in the Readme ADD: Explanation to the README.md about caching and cool down REF: Some comments and variable names ADD: The values for the default cool down and the cool down period can now be configured REF: Thread is started automatically again REF: prints REF: Comments ADD: Configuration for cool down REF: Setting the cache and the cool down config can be called on the pythonwhois package (__init__.py) FIX: Package being packaged in setup.py
REF: Made timeout an argument, but with a default value
…whois application that uses this REF: Processed Wytse his comments
…468-detect-requests-exceeded to develop * commit 'b0f201e9797179e61c31076009d9750d1ee4253e': ENH: Wording in a comment REF: Removed the fix for parsing empty responses and moved it to the whois application that uses this REF: Processed Wytse his comments REF: Renamed whois_response.py to raw_whois_response.py REF: Made timeout an argument, but with a default value REF: Increased default cool down length from 1 second to 2 REF: Extracted the starting of a cool down to a separate method ADD: Can now check whether a rate limit has been exceeded or not FIX: If there are now results at all, parse.py simply returns an empty dictionary instead of crashing ADD: A holder for WHOIS responses. It contains information about the success of the retrieval.
REF: Changed the time out for a WHOIS request to 3 seconds
…x/fix-for-gg-domains to develop * commit 'aaa7a6cba8d280f1e53d1b4498387180be0bdb0e': REF: Changed the default cooldown to 4 seconds REF: Changed the time out for a WHOIS request to 3 seconds FIX: Fixed failure for gg domains
… case of time out, because some servers block pinging which would skew the results.
ADD: If a limit is reached but the WHOIS server has already not been used for that time (say, the minute limit is reached but the server hasn't been used for a minute either) the cool down will be normal instead
… complete and whether there is a WHOIS server available. This is what is returned from get_whois_raw REF: When no WHOIS server is available, just return with a WhoisResult instance describing it
…x/now-only-check-server-when-timeout to develop * commit 'e1e572878981b5639f5e07abbece366a735cf46b': ADD: Added a new method for compatibility with the original pythonwhois ADD: WhoisResult. Contains the list of responses, whether the list is complete and whether there is a WHOIS server available. This is what is returned from get_whois_raw REF: When no WHOIS server is available, just return with a WhoisResult instance describing it REF: Changed the increase in cool down rate from 2 to 1.5 ADD: If a limit is reached but the WHOIS server has already not been used for that time (say, the minute limit is reached but the server hasn't been used for a minute either) the cool down will be normal instead FIX: postal -> postalcode DEL Checking whether the referral server is alive now only happens in case of time out, because some servers block pinging which would skew the results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADD:fix for not working referral servers.
ADD: Fall back single line regexes, which are used for fields that contain no data after using the initial regexes
FIX: facsimile is now extracted as fax, since they are equal (fax is short for facsimile)
REF: Now using spaces instead of tabs (PEP-8)
REF: Reformatted using PyCharm
ADD: Four tests for previously not working cases