-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create EN_NGHolidayStrategy.cs #205
base: master
Are you sure you want to change the base?
Create EN_NGHolidayStrategy.cs #205
Conversation
Added Nigerian holiday strategy
Hi, I'll gladly merge your PR. Can you fix the compilation errors? |
I guess C# is not your natural language. Usually we don't put more than one class per file. |
Thank you for your feedback! You’re correct; C# isn’t my primary language, and I appreciate your guidance. I’ll make sure to open the .sln file in a proper IDE like JetBrains Rider or Visual Studio Community to compile the project correctly. I also understand the convention of having one class per file and will keep that in mind moving forward. Thank you for your help! |
was this fixed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates
This pull request introduces support for Nigerian holidays in the DateTimeExtensions project. The new EN_NGHolidayStrategy class includes both fixed and movable holidays observed in Nigeria, such as:
Each holiday was added as a FixedHoliday or VariableHoliday based on its observance pattern. These updates ensure Nigerian users have localized, accurate holiday data for calculations involving non-working days.
Let me know if any adjustments are required for the new holiday definitions. Looking forward to your feedback!