Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create EN_NGHolidayStrategy.cs #205

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Aisha-Gama
Copy link

This pull request introduces support for Nigerian holidays in the DateTimeExtensions project. The new EN_NGHolidayStrategy class includes both fixed and movable holidays observed in Nigeria, such as:

•	New Year’s Day
•	Good Friday
•	Easter Monday
•	Workers’ Day
•	Eid al-Fitr (End of Ramadan)
•	Eid al-Adha (Festival of Sacrifice)
•	Maulid (Birth of Prophet Muhammad)

Each holiday was added as a FixedHoliday or VariableHoliday based on its observance pattern. These updates ensure Nigerian users have localized, accurate holiday data for calculations involving non-working days.

Let me know if any adjustments are required for the new holiday definitions. Looking forward to your feedback!

Added Nigerian holiday strategy
@joaomatossilva
Copy link
Owner

Hi, I'll gladly merge your PR. Can you fix the compilation errors?

@joaomatossilva
Copy link
Owner

I guess C# is not your natural language.
This is not a single file solution. Try to open the .sln file and use a proper IDE. You can try Jetbrains Raider or Visual Studio Community, and compile it.

Usually we don't put more than one class per file.

@Aisha-Gama
Copy link
Author

I guess C# is not your natural language.

This is not a single file solution. Try to open the .sln file and use a proper IDE. You can try Jetbrains Raider or Visual Studio Community, and compile it.

Usually we don't put more than one class per file.

Thank you for your feedback! You’re correct; C# isn’t my primary language, and I appreciate your guidance. I’ll make sure to open the .sln file in a proper IDE like JetBrains Rider or Visual Studio Community to compile the project correctly. I also understand the convention of having one class per file and will keep that in mind moving forward. Thank you for your help!

@M4SOOM
Copy link

M4SOOM commented Oct 31, 2024

was this fixed?

Repository owner deleted a comment from P300pl Nov 21, 2024
Copy link

@Domi83s Domi83s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants