Adds a pass-thru arg for Mocha grep support

[tim-pg]

Adds a pass-thru arg for Mocha grep support when running from the command line.

[tim-pg]

@jfirebaugh Hi John -- does this seem ok?

[jfirebaugh]

Hi @tim-pg, and thanks for the contribution. I'm leaning towards "no" on this. I realize there's a precedent here with SPEC and FORMAT, but think it was a mistake to introduce the use of environment variables to control what would more conveniently be specified via command line arguments. Rather than expanding the use of environment variables, I would prefer to introduce a real CLI interface (#149).

[tim-pg]

Sure I feel the same way. Do you have a preference on how you'd like that done (there are of course various options)? Anyway yeah I can switch this to use an arg, then followup to make the other extant env vars work via args instead.

Also, that aside, are you OK with the basic idea of appending the grep query parameter and letting Mocha pick it up from there?

[jfirebaugh]

Let's start simple, just using the stdlib OptionParser.

Also, that aside, are you OK with the basic idea of appending the grep query parameter and letting Mocha pick it up from there?

👍

[tim-pg]

@jfirebaugh Ok this has been updated.

Note that ENV support is completely replaced, which may be a back-compat issue... or maybe not, your call.

[tim-pg]

@jfirebaugh Hi John, how's this looking? Anything you'd like tweaked? Thanks--

[jfirebaugh]

What I had in mind was actually moving the existing env var support out to the rake tasks (we do need to keep supporting that), and providing a standalone konacha binary.

konacha serve
konacha run
konacha run foo_spec bar_spec
konacha run --grep "reticulates splines"
konacha run --formatter CI::Reporter::RSpec

The binary has to load up the Rails environment somehow -- I guess look at what rake environment does for that.

[Mange]

You require config/boot.rb or config/environment.rb (can't remember
which).
Den 26 aug 2014 18:05 skrev "John Firebaugh" [email protected]:

What I had in mind was actually moving the existing env var support out to
the rake tasks (we do need to keep supporting that), and providing a
standalone konacha binary.

konacha serve
konacha run
konacha run foo_spec bar_spec
konacha run --grep "reticulates splines"
konacha run --formatter CI::Reporter::RSpec

The binary has to load up the Rails environment somehow -- I guess look at
what rake environment does for that.

—
Reply to this email directly or view it on GitHub
#181 (comment).

[tim-pg]

Ok-- I misunderstood what you meant by "real CLI interface", sorry about that. Ok, I'll take a stab at a standalone binary.

1. Let me make sure I understand what this part means: "moving the existing env var support out to the rake tasks". I am assuming you mean read the env vars in the rake task but then use them as though they had been specified on the command line, i.e., don't directly refer to ENV anymore in the actual code. Is that right?

2. Also -- you said "out to the rake tasks" (plural) -- but just to clarify, you only mean one task (singular). I.e., these options aren't meant affect the way serve works, only run, yes (?)

[jfirebaugh]

Yes, right, just konacha:run. Something like:

  task :run => :environment do
    if ENV['FORMAT']
      Konacha.config.formatters = ENV['FORMAT'].split(',').map do |string|
        eval(string).new(STDOUT)
      end
    end

    if ENV["SPEC"]
      Konacha.config.spec = ENV["SPEC"].split(",")
    end

    passed = Konacha.run
    # Apparently there is no canonical way to fail a rake task other than
    # throwing an exception or exiting.
    # http://stackoverflow.com/a/5117457/525872
    exit 1 unless passed
  end