Generate a default closure in InterceptingGCL

[nestoracunablanco]

In case a method is matched with null value closure, the default generated closure is {}.

This does not work when the method has more parameters, so the approach of generating a default closure using dynamic compilation was taken.

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

Solves comments in issue #461

[nre-ableton]

There is a lot of logic going on in defaultClosure that isn't tested. It would be nice to have a unit test to make sure that all of the string slicing and appending works as expected.

Also, there is a typo in the commit message (it should be "Generate a default ..."). I fixed this in the PR title for you.

[nestoracunablanco]

@nre-ableton more unit tests are now in place.

[nre-ableton]

I guess this change looks fine to me, but I am not sure I can speak to the broader impact that this change may have. It would be nice if @stchar could also take a look.

[nestoracunablanco]

Hi @stchar, can you please also take a look at this pull request? Thanks!

[stchar]

Awesome!

[stchar]

@nestoracunablanco, @nre-ableton, reviewed. Looks good.
I would also add tests for scripted pipeline, but I assume there is no any difference as InterceptingGCL address to metaclass of groovy.lang.Script which is the same in case of Declarative and Scripted pipeline test runs.

[nestoracunablanco]

Thanks for the nice feedback!