Fix LiveTV Playback #6166
Fix LiveTV Playback #6166
Conversation
viown
force-pushed
the
fix-livetv-playback
branch
from
4e2a3de
to
95e2387
Compare
|
Cloudflare Pages deployment
|
| @@ -2611,9 +2611,11 @@ export class PlaybackManager { | |||
| autoSetNextTracks(prevSource, mediaStreams, trackOptions, user.Configuration.RememberAudioSelections, user.Configuration.RememberSubtitleSelections); | |||
| if (trackOptions.DefaultAudioStreamIndex != null) { | |||
| options.audioStreamIndex = trackOptions.DefaultAudioStreamIndex; | |||
| mediaSourceId = mediaSourceId || item.Id; | |||
There was a problem hiding this comment.
It's weird to do it here. We can probably leave mediaSourceId undefined as it was before the stream fix. I guess the server uses item Id when media source Id is not specified.
There was a problem hiding this comment.
From my testing, DefaultSubtitleStreamIndex and DefaultAudioStreamIndex don't always get set according to options.subtitleStreamIndex and options.audioStreamIndex unless mediaSourceId is defined.
There was a problem hiding this comment.
Probably because of this? https://github.com/jellyfin/jellyfin/blob/master/Jellyfin.Api/Helpers/MediaInfoHelper.cs#L197
|
@dmitrylyzo Also is mediaSourceId not working with live TV a server bug? (returns NoCompatibleStream). Would it be better to fix this on the server than workaround it here? |
Probably. Here and here Possible fix: we can make them mutually exclusive: jellyfin-web/src/components/playback/playbackmanager.js Lines 459 to 464 in 3a33ed9 if (liveStreamId) {
query.LiveStreamId = liveStreamId;
} else if (mediaSourceId) {
query.MediaSourceId = mediaSourceId;
}There was a regression in the server that was recently fixed. Made a comment on that issue. But now I think that it fails here. I am surfing the code from mobile and could be wrong. |
|
I should note that liveStreamId isn't set by |
Fixes LiveTV playback not working when specifying mediaSourceId
Changes
Issues
Fixes #6164