Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete old thumbnails from the media/cache directory and the database #733

Closed
wants to merge 5 commits into from

Conversation

LarryMartell
Copy link
Contributor

@LarryMartell LarryMartell commented Jul 18, 2023

Address issue #721

@uri-rodberg
Copy link
Contributor

Do you know why tests failed or canceled?

@uri-rodberg
Copy link
Contributor

@LarryMartell Can you rebase your PR on branch master?

@LarryMartell
Copy link
Contributor Author

@LarryMartell Can you rebase your PR on branch master?

Done

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #733 (d11b110) into master (4e77896) will decrease coverage by 0.67%.
The diff coverage is 38.70%.

❗ Current head d11b110 differs from pull request most recent head 337a51f. Consider uploading reports for the commit 337a51f to get more accurate results

@@            Coverage Diff             @@
##           master     #733      +/-   ##
==========================================
- Coverage   74.11%   73.45%   -0.67%     
==========================================
  Files          30       30              
  Lines        1700     1729      +29     
==========================================
+ Hits         1260     1270      +10     
- Misses        440      459      +19     
Impacted Files Coverage Δ
sorl/thumbnail/management/commands/thumbnail.py 81.13% <33.33%> (-18.87%) ⬇️
sorl/thumbnail/kvstores/base.py 87.27% <40.00%> (-7.52%) ⬇️
sorl/thumbnail/conf/defaults.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@uri-rodberg
Copy link
Contributor

uri-rodberg commented Jul 25, 2023

Please wait with this PR and don't do anything until we finish merging #739 .

@uri-rodberg uri-rodberg marked this pull request as draft August 1, 2023 01:51
@LarryMartell LarryMartell marked this pull request as ready for review August 1, 2023 12:51
@uri-rodberg
Copy link
Contributor

@LarryMartell Please contact me by email. Your mailbox is full.

@uri-rodberg uri-rodberg marked this pull request as draft August 1, 2023 16:57
@uri-rodberg
Copy link
Contributor

I'm closing this PR. There is a new PR - #740.

@uri-rodberg uri-rodberg closed this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants