Always set testing cookies, even on pages which do not use them #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragon-dxw
force-pushed
the
always-set-cookies
branch
from
267d899 to
6d9edf5
Compare
Addresses #80 Uses code from OpenHumans/open-humans#1109
dragon-dxw
force-pushed
the
always-set-cookies
branch
from
6d9edf5 to
473771b
Compare
|
Taking another look, I think there's a slight issue with my changes to the tests -- we no longer test whether the results of the flag toggle are instantly available at the instant of having been run. If people make good noises I'll fix that (by broadly replicating the original test) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #80
Uses code from OpenHumans/open-humans#1109
Modifies the tests slightly to attempt to set the cookie on a page which doesn't make use of waffle.