Make is_active_for_user consider when everyone is False #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chess-octane
force-pushed
the
everyone-false-user
branch
from
6314e06 to
df88581
Compare
renvieir
reviewed
Feb 21, 2024
renvieir
reviewed
Feb 21, 2024
minhtrangvy
approved these changes
Apr 18, 2024
minhtrangvy
reviewed
Apr 18, 2024
| @@ -233,6 +233,9 @@ def is_active_for_user(self, user: AbstractBaseUser) -> bool | None: | |||
| if self.everyone: | |||
There was a problem hiding this comment.
maybe want to make this if self.everyone is True?
minhtrangvy
suggested changes
Apr 18, 2024
There was a problem hiding this comment.
actually we have a usecase where we rely on is_active_for_user NOT respecting the "everyone" attribute in order to create feature flags that are on just for some users and not all
maybe this should be a required param on whether to respect everyone or not, otherwise i could see a lot of issues when people upgrade waffle because of this behavior change
|
I disagree with @minhtrangvy. This is a bug in the code. The documentation makes it clear what the expectation for the |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check to the
is_active_for_usermethod to consider when the attributeeveryoneis False.Fixes #401