Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

632 Delete Requests #637

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

632 Delete Requests #637

wants to merge 5 commits into from

Conversation

ashfaq1934
Copy link

  • Adds a button to each request card and detail page which allows you to delete individual request without having to click clear db.
  • Resolves Allow to delete some requests #632

@codecov
Copy link

codecov bot commented Jan 1, 2023

Codecov Report

Merging #637 (17b423f) into master (415529c) will increase coverage by 0.45%.
Report is 13 commits behind head on master.
The diff coverage is 45.45%.

@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
+ Coverage   86.42%   86.88%   +0.45%     
==========================================
  Files          52       52              
  Lines        2078     2189     +111     
==========================================
+ Hits         1796     1902     +106     
- Misses        282      287       +5     
Files Coverage Δ
silk/views/request_detail.py 78.78% <45.45%> (-16.87%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ashfaq1934 ashfaq1934 self-assigned this Jan 4, 2023
@albertyw albertyw force-pushed the 632-delete-requests branch from dd3d71e to b10d04a Compare January 5, 2023 10:05
silk/views/request_detail.py Outdated Show resolved Hide resolved
@ashfaq1934 ashfaq1934 requested a review from gopar November 2, 2023 10:31

def test_delete(self):
response = self.client.post(reverse('silk:request_detail', kwargs={'request_id': str(self.request.id)}))
self.assertEqual(response.status_code, HTTPStatus.FOUND)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests! A few nitpicks:

  • Can you make sure that this re-routes to the summary page and the object is deleted. (Bonus for test that checks the redirection for header Referer)
  • Another test that checks when we pass in a non-existing request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to delete some requests
2 participants