support interruption level on ios devices #711
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We never know when we might be implementing or extending the `django-push-notifications` library beyond its current support. It makes sense to have a module to handle critical moments such as that raised in #708 (for `interruption-levels`). This gives control over newly implemented interfaces without having to worry about outdated modules, such as `PyAPNS2`. This allows us to provide wrapper or extend existing library functionalities. Context: This patch address one side of issue by providing an enumeration module that can be used to deal with public and underlying APIs.
for Apple Devices Digging deep into `PyAPNs2`, I found that the library does have internal priority levels, distinctively, `Immediate` and `Delayed`. In addition to this, support different notification types, such as `Background`, `Alert`, `VoIP`, `Complication`, `FileProvider` and `mdm`. This patch extend one or two of these interfaces to support `interruption_levels` on User Notification Center. Below is what is contained in this commit: - [x] New enumeration types to support interruption levels: `time_sensitive`, `active`, `passive`, `critical` alerts - [x] Wrapper functions to help add additional functionality to existing `_apns_send` and `_apns_prepare` methods. This design allows for modification of functionality without breaking backwards compatibility, and also giving control over what-is-what.
|
Your PR is difficult to review because of whitespace changes. If there are whitespace fixes to make, please do them in a separate commit/PR. |
|
That was my editor overriding the editorconfig settings, I think I would have to find a way make it respect With that pointed out, i'd try see to revert to previous change. |
50-Course
changed the title
|
Underlying dep has been migrated to aiopns - new PR for this context would be raised. Closing this for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello team,
Digging deep into
PyAPNs2, I found that the library does have internalpriority levels, distinctively,
ImmediateandDelayed.In addition to this, support different notification types, such as
Background,Alert,VoIP,Complication,FileProviderandmdm.This patch extend one or two of these interfaces to support
interruption_levelson User Notification Center. Below is what iscontained in this commit:
time_sensitive,active,passive,criticalalerts_apns_sendand_apns_preparemethods. This design allows formodification of functionality without breaking backwards
compatibility, and also giving control over what-is-what.
NOTE: This should be tested on real Apple devices or emulators
before merged.
This patch is a work-in-progress and I would like to get feedback on
this before I proceed with the next steps. Can you take a look at this? @pomali
CC: @jleclanche
Commits:
interruption_leveltoapns_send_message()function signatureapns_send_message()interface