Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename PAYMENT_VARIANTS to PAYMENT_VARIANTS_API #137

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

devkral
Copy link
Contributor

@devkral devkral commented Jun 18, 2017

fix issue #64
this should prevent credentials appearing in the log

@devkral
Copy link
Contributor Author

devkral commented Jun 18, 2017

patterns are
HIDDEN_SETTINGS = re.compile('API|TOKEN|KEY|SECRET|PASS|SIGNATURE', flags=re.IGNORECASE)

@codecov-io
Copy link

codecov-io commented Jun 18, 2017

Codecov Report

Merging #137 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #137   +/-   ##
=======================================
  Coverage   79.13%   79.13%           
=======================================
  Files          27       27           
  Lines        1649     1649           
  Branches      190      190           
=======================================
  Hits         1305     1305           
  Misses        245      245           
  Partials       99       99
Impacted Files Coverage Δ
payments/core.py 87.69% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49c93aa...d68e21d. Read the comment docs.

@devkral
Copy link
Contributor Author

devkral commented Jun 19, 2017

hm, most probably some broken tests (django 1.11), I have fixed some in my branch:
payment_improvements
has some very disruptive changes so I won't create a pull request before being sure that everything works fine

@devkral devkral force-pushed the fix_64_variants_name branch from 429df91 to d68e21d Compare October 6, 2017 15:03
@devkral
Copy link
Contributor Author

devkral commented Oct 6, 2017

now it should work

@devkral
Copy link
Contributor Author

devkral commented Oct 6, 2017

this change can save your keys if you have a bad day and enable debug in django.settings

@mariofix
Copy link
Member

@WhyNotHugo should we resume this?

@WhyNotHugo
Copy link
Member

It can be rebased, but we likely want to maintain backwards compatibility with the previous name.

@mariofix mariofix self-assigned this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants