Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client_secret to sensitive_post_parameters #1512

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

jaap3
Copy link
Contributor

@jaap3 jaap3 commented Oct 3, 2024

The client_secret is posted to the token endpoint when using the client_credentials grant.

(sorry just a basic drive-by PR because I noticed this while debugging something else)

The client_secret is posted to the token endpoint when using the client_credentials grant.
Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@n2ygk n2ygk merged commit ce34da4 into jazzband:master Oct 7, 2024
19 checks passed
@n2ygk n2ygk added this to the Release 3.1.0 milestone Oct 7, 2024
@matejsp
Copy link
Contributor

matejsp commented Nov 13, 2024

Any chance to have this fix released?
This looks like security issue when used with error capture like sentry or logging and would need release ASAP.

@jaap3 jaap3 deleted the patch-1 branch December 10, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants