Minor refactor to allow for saving AnimLayers

[neph1]

While working on this jMonkeyEngine/sdk#612 I found out that AnimLayers couldn't be saved.

Tested in local SDK.

I'll look it over once more before turning into a proper PR.

The tests don't explicitly test the changes, just general AnimComposer behavior.

[neph1]

redundant field

[neph1]

I decided to only save name and mask. The other fields felt like they're only interesting for runtime.

[pspeed42]

Note that in my case, it's actions that give me heartburn for not being persisted. But my memory is that there are more demons down that rabbit hole.

But it does mean that for every model rig I load, I have to do a loop like this with my own external fix-up config:

            for( BlendInfo blend : blends ) {
                BlendAction ba = anim.actionBlended(blend.getName(), new LinearBlendSpace(0, 1),
                                                    blend.getBlendedActions());
                ba.getBlendSpace().setValue((float)blend.getDefaultBlend());
            }

Actions enter this weird area where I can see defining them one-off in code to do some particular thing... while also wanting to preconfigure some with masks and blending and so on. But also, every other thing in JME operates this way... if I tweak a "runtime to me" material parameter and then save that j3o then it gets saved. So I'm not sure I buy arguments against saving them.

[neph1]

If I can find a use case from the SDK's perspective, I don't mind making Actions Savable too (I actually started it). But atm I don't see exactly how you would use them. In any case, that's for another PR.

[capdevon]

To enhance clarity and facilitate review, please submit the optimizations as a separate pull request (PR). This will prevent confusion and simplify potential rollbacks. By separating these changes, you can maintain the flexibility to revert optimizations without affecting the core functionality.

Edit:
Please excuse me if I seem overly formal. I'm not trying to be harsh. After years of reviewing software, I'm simply applying the guidelines outlined in the JME code of conduct.
Thank you for your work and understanding

[capdevon]

Ok, everything looks good to me. Thank you.

[neph1]

Does anyone have to officially approve it? Or do I just merge it?

[stephengold]

Does anyone have to officially approve it? Or do I just merge it?

The project isn't very formal these days. Merge when ready.