Upgrade spotbugs to 4.8.6 #2295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading spotbugs versions.
To run spotbugs, I run:
./gradlew build -PenableSpotBugs=true
This generates the html report in build/reports/spotbugs, for each gradle subproject. I can see that there are a whole bunch of new lints in there for the engine. Because we don't block on spotbugs, this won't start failing any CI or builds, nor will it print any warnings while building. It just creates the report, when you turn on spotbugs with the flag, so this should be a safe change. We can later look at the reports and start fixing some of the issues.