Add MipMaps to PBRTerrainAdvancedTest.java #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test case has some noisey rendering that are due to not setting mipMaps on the TextureArray. So I added the MinFilter.Trilinear to fix this issue, and also added MagFilter.Bilinear.
scenemax3d
pushed a commit
that referenced
this pull request
Jul 5, 2024
This test case has some noisey rendering that are due to not setting mipMaps on the TextureArray. So I added the MinFilter.Trilinear to fix this issue, and also added MagFilter.Bilinear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test case has some noisey rendering due to not setting MipMaps on the terrain material's TextureArrays.
So I added MinFilter.Trilinear to fix this issue, and also added MagFilter.Bilinear.
I don't know much about the different MipMap settings, but MinFilter.Trilinear appeared to create the smoothest results for the terrain in this test case (and my own projects), so I went with that.