-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1877: Add checkstyle to project #2042
Merged
stephengold
merged 7 commits into
jMonkeyEngine:master
from
andygibson:1877-add-checkstyle-to-project
Aug 1, 2023
Merged
1877: Add checkstyle to project #2042
stephengold
merged 7 commits into
jMonkeyEngine:master
from
andygibson:1877-add-checkstyle-to-project
Aug 1, 2023
Commits on Jul 23, 2023
-
1877: Add checkstyle to project
Add checkstyle plugin to common.gradle Add a checkstyle.xml based on google checkstyle xml with ammendments. Checkstyle errors do not fail the build, everything is marked as a warning, can be refined over time as per comments in jMonkeyEngine#1877. Checkstyle can be run with `./gradlew checkstyleMain` - it runs for all projects.
Configuration menu - View commit details
-
Copy full SHA for aebdfa0 - Browse repository at this point
Copy the full SHA aebdfa0View commit details
Commits on Jul 24, 2023
-
1877: Updated to work with Java 8
Wound back checkstyle version to 9.3 Last good version to work out of the box with java 8 Re-copied the google checkstyle config from that version too Updated the links in the checkstyle config to the right docs url. Rebuilt with Java 8 & 17 to test.
Configuration menu - View commit details
-
Copy full SHA for a0676e1 - Browse repository at this point
Copy the full SHA a0676e1View commit details -
1877: Reduce checks to limit output
* Ignore some modules that produce a lot of warnings. * Increase line length to 150 so we only get the worst offenders * Reduces output by ~70% (counting main.html sizes, about 4M)
Configuration menu - View commit details
-
Copy full SHA for ac1b34c - Browse repository at this point
Copy the full SHA ac1b34cView commit details -
* Don't run checkstyle on jme3-networking and jme3-vr * These two make up about 1M of reporting * Fixed ref to checkstyle-suppressions and added a template file * Removed suppressionXPathFilter * Disabled a couple more checks. * Output is down to ~ 2.2M
Configuration menu - View commit details
-
Copy full SHA for 3a8e052 - Browse repository at this point
Copy the full SHA 3a8e052View commit details
Commits on Jul 25, 2023
-
1877: Further refinement of output
* Only process /com/jme3/renderer sources * Rolled back jme3-network/vr exclusion (still not processed though) * Added modules back into checkstyle config * Now gives 38 errors from 11 files within com/jme3/renderer package * BeforeExecutionExclusionFileFilter wasn't playing nicely
Configuration menu - View commit details
-
Copy full SHA for 211a35f - Browse repository at this point
Copy the full SHA 211a35fView commit details -
* Realised I made a mistake on the package filter * was only pulling java classes directly under com/jme/renderer/ * Ammded to include all java classes in that package * Opened up to 200Kb of errors over 4 projects
Configuration menu - View commit details
-
Copy full SHA for 751dd26 - Browse repository at this point
Copy the full SHA 751dd26View commit details
Commits on Jul 27, 2023
-
* Made style changes suggested in the PR comments
Configuration menu - View commit details
-
Copy full SHA for 31b5b9e - Browse repository at this point
Copy the full SHA 31b5b9eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.