Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1877: Add checkstyle to project #2042

Merged

Commits on Jul 23, 2023

  1. 1877: Add checkstyle to project

    Add checkstyle plugin to common.gradle
    Add a checkstyle.xml based on google checkstyle xml with ammendments.
    Checkstyle errors do not fail the build, everything is marked as a
    warning, can be refined over time as per comments in jMonkeyEngine#1877.
    
    Checkstyle can be run with `./gradlew checkstyleMain` - it runs for all
    projects.
    andygibson committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    aebdfa0 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. 1877: Updated to work with Java 8

    Wound back checkstyle version to 9.3
    Last good version to work out of the box with java 8
    Re-copied the google checkstyle config from that version too
    Updated the links in the checkstyle config to the right docs url.
    Rebuilt with Java 8 & 17 to test.
    andygibson committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    a0676e1 View commit details
    Browse the repository at this point in the history
  2. 1877: Reduce checks to limit output

    * Ignore some modules that produce a lot of warnings.
    * Increase line length to 150 so we only get the worst offenders
    * Reduces output by ~70% (counting main.html sizes, about 4M)
    andygibson committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    ac1b34c View commit details
    Browse the repository at this point in the history
  3. Reduced checkstyle output

    * Don't run checkstyle on jme3-networking and jme3-vr
    * These two make up about 1M of reporting
    * Fixed ref to checkstyle-suppressions and added a template file
    * Removed suppressionXPathFilter
    * Disabled a couple more checks.
    * Output is down to ~ 2.2M
    andygibson committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    3a8e052 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. 1877: Further refinement of output

    * Only process /com/jme3/renderer sources
    * Rolled back jme3-network/vr exclusion (still not processed though)
    * Added modules back into checkstyle config
    * Now gives 38 errors from 11 files within com/jme3/renderer package
    * BeforeExecutionExclusionFileFilter wasn't playing nicely
    andygibson committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    211a35f View commit details
    Browse the repository at this point in the history
  2. 1877: Fixed package filter

    * Realised I made a mistake on the package filter
    * was only pulling java classes directly under com/jme/renderer/
    * Ammded to include all java classes in that package
    * Opened up to 200Kb of errors over 4 projects
    andygibson committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    751dd26 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. 1877: Fixed some style rules

    * Made style changes suggested in the PR comments
    andygibson committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    31b5b9e View commit details
    Browse the repository at this point in the history