Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FROZEN] Re-add ivo_epoch_prop #20

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[FROZEN] Re-add ivo_epoch_prop #20

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d31ea0c
Improving the rules for NULL-ing out output values in epoch_prop.
msdemlei May 15, 2024
be4ae03
In epoch_prop_pos, shunt through RV for NULL parallaxes.
msdemlei May 22, 2024
df9e3eb
More consistent NULL encoding in epoch_prop responses.
msdemlei May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 38 additions & 2 deletions udf-catalogue.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,8 +401,12 @@ \subsubsection{ivo\_epoch\_prop(ra, dec, parallax, pmra, pmdec,
parameters, the proper motion in longitude is given for the tangential
plane (``has ${\textrm cos}(\delta)$ applied'').

Items that are NULL on input MUST be NULL (in VOTable arrays, NaN) on
output, and when a single component of the proper motion is NULL, the
other component must be NULL-ed out on output, too. Similarly, when a
NULL parallax is passed in, the RV must be NULL-ed out on output, too.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does a NULL input parallax require a NULL output rv? If the rv is OK on input but you don't happen to have a parallax for it, the same rv should be a reasonable value for the propagated version. Am I missing something?


\item[Source] This document, version 1.1
\item[Source] This document, version 1.2
\end{description}

\begin{examples}
Expand All @@ -412,11 +416,34 @@ \subsubsection{ivo\_epoch\_prop(ra, dec, parallax, pmra, pmdec,
\end{lstlisting}
\becomes [7.6040614046279735, 11.793270382827929, 125.01993165584682,\\
300.09877325973605, -428.934593565712, 52.50880381775256]

\example \begin{lstlisting}
ivo_epoch_prop(7.606083572, 11.79044105, 125,
NULL, NULL, NULL, 2016.0, 1992.25)
\end{lstlisting}
\becomes [7.606083572000001, 11.79044105, 125.0, 0.0, 0.0, 0.0]
\becomes [7.606083572, 11.79044105, 125, NULL, NULL, NULL]

\example \begin{lstlisting}
ivo_epoch_prop(7.606083572, 11.79044105, NULL,
300, -428.8, 52.51, 2016.0, 1992.25)
\end{lstlisting}
\becomes [7.604061727024453, 11.79326993174991, NaN, \\
300.0030911918108, -428.79783514643105, NaN]

\example \begin{lstlisting}
ivo_epoch_prop(7.606083572, 11.79044105, 125,
21, NULL, NULL, 2016.0, 1992.25)
\end{lstlisting}
\becomes [7.606083572000001, 11.79044105, 125.0, NULL, NULL, NULL]

\example \begin{lstlisting}
ivo_epoch_prop(7.606083572, 11.79044105, 125,
300, -428.8, NULL, 2016.0, 1992.25)
\end{lstlisting}
\becomes [7.604061727024712, 11.793269931749549, 124.9999997730655,\\
300.0030911152833, -428.79783503705033, NULL]


\end{examples}

\subsubsection{ivo\_geom\_transform(from\_sys, to\_sys, geo)}
Expand Down Expand Up @@ -937,6 +964,7 @@ \subsubsection{ivo\_hms\_to\_degrees(hms)}

\item[Return type] \texttt{REAL}

\item[Source] This document, version 1.2
\end{description}

\begin{examples}
Expand Down Expand Up @@ -967,6 +995,7 @@ \subsubsection{ivo\_dms\_to\_degrees(dms)}

\item[Return type] \texttt{REAL}

\item[Source] This document, version 1.2
\end{description}

\begin{examples}
Expand Down Expand Up @@ -1004,6 +1033,13 @@ \subsubsection{ivo\_dms\_to\_degrees(dms)}

\section{Changes from Previous Versions}

\subsection{Changes from PEN-20240409}

\begin{itemize}
\item Now prescribing that \verb|ivo_epoch_prop| has to NULL out
output values that were NULL on input.
\end{itemize}

\subsection{Changes from EN-1.1}

\begin{itemize}
Expand Down