Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes Markus D. review reports #28

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fixes Markus D. review reports #28

wants to merge 4 commits into from

Conversation

molinaro-m
Copy link
Member

This pull request covers the review points raied by @msdemlei (if approved).

msdemlei
msdemlei approved these changes Sep 30, 2024
View reviewed changes
Copy link

@msdemlei msdemlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; if there were more interesting changes, I'd advocate splitting the reflowing and the content-chaning parts into two commits, but since it's all rather editorial or technical stuff, I'd say let's go and upload a PEN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msdemlei msdemlei msdemlei approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@molinaro-m @msdemlei