Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quotedblbase shows both quote signs google/fonts#129 #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

graphicore
Copy link

Apparently, quotedblbase consisted already of two comma components but
they were on the same spot.

NOTE: I replaced the comma components in quotedblbase and in quotesinglbase
with components of quoteright, because the bold comma is heavier than the
bold quoteright and that caused an imbalance between the base-line quotes
and the upper quotes.

Apparently, quotedblbase consisted already of two comma components but
they were on the same spot.

NOTE: I replaced the comma components in quotedblbase and in quotesinglbase
with components of quoteright, because the bold comma is heavier than the
bold quoteright and that caused an imbalance between the base-line quotes
and the upper quotes.
Copy link

@CoperNick8 CoperNick8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I don't know how to check it visually.

@graphicore
Copy link
Author

On the "View changes" site you can click "View" and there "Download" to download my Poppins.glyphs file. This is the download link then: https://github.com/graphicore/poppins/raw/d5d48759fdb83fcb423109ef2b396ce447c524d9/masters/Poppins.glyphs
Best use a right click and choose "Save Link As…" otherwise the file will probably open in your Browser as a text file.

@CoperNick8
Copy link

CoperNick8 commented Feb 7, 2017

I'm new to fonts. I know how to download .glyphs file, but I don't know how to "test it visually" - I mean to see how it is rendered i.e. in browser.

Yesterday I was writing review for some new web page using Poppins font and I found bug. Then I found your fix. Then I thought that it would be fun to fix Poppins font instead of changing Poppins font to different font.

EDIT: OK now I know that I should buy a Mac probably. Also I have errors when trying to run build.py . It looks that my firs attempt to Type Design fails.

@davelab6
Copy link

davelab6 commented Dec 8, 2017

@satyarajpurohit @lianghai please take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants