-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: response_code in redirect_uri #257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppelinux
reviewed
Sep 6, 2024
peppelinux
reviewed
Sep 6, 2024
peppelinux
reviewed
Sep 6, 2024
peppelinux
reviewed
Sep 6, 2024
peppelinux
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request advances the post authentication flow to what is described in version 0.8.0 of https://github.com/italia/eudi-wallet-it-docs
It introduces a redirect uri containing a
response_code
that is opaque to the Wallet Instance and/or User Agent (based on cross device or same device flow).This closes #251 by implementing strategy 3 discussed here #251 (comment)
AES-GCM was used as a the algorithmic choice of authenticated encryption as suggested by the book Real-World Cryptography by David Wong, chapter 4.5 .