Relying Party security considerations for Cross Device Flow #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the cross device flow
grausof
reviewed
Aug 2, 2023
grausof
requested changes
Aug 3, 2023
docs/en/relying-party-solution.rst
Outdated
Comment on lines
147
to
150
| .. code-block:: text | ||
|
|
||
| eudiw://authorize?client_id=https://verifier.example.org&request_uri=https://verifier.example.org/request_uri | ||
|
|
There was a problem hiding this comment.
I understand that this will be the content of the QR code. If so, how will the RP backend distinguish one request from another?
In this way the qr code will be static and identical for everyone
There was a problem hiding this comment.
it is a non normative example but anyway we should decide it the reuqest_uri is the same but with urlparams ?state=$that-state or having dynamic request_uri (and then outside of the wallet relying party metadata) that are related to different request_objects (available in the queue)
I think that it would be better taking the JARM recommendation, remove the request_uri from the metadata, and have random request_uri bound to specific state.
@grausof do you agree?
fmarino-ipzs
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the same url scheme used in the cross device also for the same device
it also adds a section related to the security considerations about how a cross device flow should secure the user-agent session