fix!: credential_definition.type is a single value #85
Conversation
peppelinux
added
issuance
standardization
| @@ -137,7 +137,7 @@ The JWS payload of the request object is represented below: | |||
| "type":"openid_credential", | |||
| "format": "vc+sd-jwt", | |||
| "credential_definition": { | |||
| "type": ["PersonIdentificationData"] | |||
| "type": "PersonIdentificationData" | |||
| } | |||
| } | |||
| ], | |||
There was a problem hiding this comment.
authorization_details is an array, and each credential authorization is a json object, then requesting multiple credentials is possible by specifing type, format and credential definition.
fair enough I'd say
There was a problem hiding this comment.
a small deviation from the sd-jwt vc spec
Given this deviation, should we briefly explain this choice with a small paragraph in the docs? That may be helpful for readers to reckon we are still in the realm of sd-jwt, and we took a motivated choice.
See also here.
That PR is still open and the discussion is still ongoing. Should we wait before assuming it right?
|
@balanza "that deviation" is resolved in this PR it was that singlevalued vs the multivalued, as it was before |
There's a small deviation from the sd-jwt vc spec, given by the authorization details example that uses the parameter type as an array and not as literal string.
when we have defined it we assumed that the type should be multivalued, this have been consolidated now in the sd-jwt vc using the single valued approach.
See also here.