Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Wallet Instance Attestation typ value according to VC HAIP #67

Merged
merged 1 commit into from
Jul 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/common/common_definitions.rst
Original file line number Diff line number Diff line change
Expand Up @@ -57,5 +57,6 @@
.. _DPOP: https://datatracker.ietf.org/doc/html/draft-ietf-oauth-dpop
.. _RFC 7519: https://www.rfc-editor.org/rfc/rfc7519
.. _OAUTH2: https://www.rfc-editor.org/rfc/rfc6749
.. _OPENID4VC-HAIP: https://vcstuff.github.io/oid4vc-haip-sd-jwt-vc/draft-oid4vc-haip-sd-jwt-vc.html


4 changes: 3 additions & 1 deletion docs/common/standards.rst
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,6 @@ Technical References
* - :rfc:`6749`
- The OAuth 2.0 Authorization Framework
* - `DPOP`
- TBD
- D. Fett, B. Campbell, J. Bradley, T. Lodderstedt, M. Jones, D. Waite, "OAuth 2.0 Demonstrating Proof-of-Possession at the Application Layer (DPoP)"
* - `OPENID4VC-HAIP`
- Lodderstedt, T., K. Yasuda, "OpenID4VC High Assurance Interoperability Profile with SD-JWT VC"
15 changes: 5 additions & 10 deletions docs/en/wallet-instance-attestation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -369,15 +369,10 @@ Header
| kid | Key id used by the Wallet |
| | Provider to sign the attestation. |
+-----------------------------------+-----------------------------------+
| typ | Media type, in this case we use |
| | the value va+jwt (Verifiable |
| | Assertion JWT). |
| | This parameter is currently |
| | non-standard as it is not yet |
| | registered as `IANA Media |
| | Types <https://www.iana.org/assig |
| | nments/media-types/media-types.xh |
| | tml>`__. |
| typ | Media type, set to |
| | `wallet-attestation+jwt`, |
| | according to |
| | [`OPENID4VC-HAIP`_] |
+-----------------------------------+-----------------------------------+
| x5c | Array containing the X.509 |
| | certificate (and the entire chain |
Expand Down Expand Up @@ -478,7 +473,7 @@ Below is an example of Wallet Instance Attestation:
"eyJhbGciOiJFUz...jJLA",
"eyJhbGciOiJFUz...H9gw",
],
"typ": "va+jwt",
"typ": "wallet-attestation+jwt",
"x5c": ["MIIBjDCC ... XFehgKQA=="]
}
.
Expand Down