Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wallet Attestation response code and method #287

Merged
merged 8 commits into from
Jun 27, 2024

Conversation

grausof
Copy link
Collaborator

@grausof grausof commented May 23, 2024

This PR aligns the Wallet Attestation request with the REST specification

@grausof grausof added this to the 0.7.1 milestone May 29, 2024
Copy link
Collaborator

@fmarino-ipzs fmarino-ipzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add the normative text according to the non normative examples

@grausof
Copy link
Collaborator Author

grausof commented Jun 17, 2024

Please, add the normative text according to the non normative examples

Can you give an example? Originally there was no other additional text

@peppelinux
Copy link
Member

Please, add the normative text according to the non normative examples

Can you give an example? Originally there was no other additional text

During the weekly meeting we agreed that along with the non normative example we need to better clarify the beahviour of the implementations using normative language and clear definition about the requirements these must satisfy

therefore we decided that this PR requires normative language within the appropriate section describing the result represented in the non normative examples

@peppelinux peppelinux self-requested a review June 21, 2024 12:02
grausof and others added 3 commits June 27, 2024 09:09
@grausof grausof merged commit c9f1eca into versione-corrente Jun 27, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants