fix: Presentation of SD-JWT are not enveloped anymore in a VP JWT #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-wallet-docs into versione-corrente
…t-wallet-docs into versione-corrente
…t-wallet-docs into versione-corrente
…t-wallet-docs into versione-corrente
…t-wallet-docs into versione-corrente
…t-wallet-docs into versione-corrente
fmarino-ipzs
approved these changes
May 2, 2024
Co-authored-by: fmarino-ipzs <[email protected]>
|
@peppelinux are you sure that this PR close the issue #299 ? We probably have to align also the data model section. |
hevelius
reviewed
Jul 11, 2024
peppelinux
commented
Jul 11, 2024
peppelinux
commented
Jul 11, 2024
peppelinux
commented
Jul 11, 2024
peppelinux
commented
Jul 11, 2024
grausof
approved these changes
Jul 30, 2024
peppelinux
commented
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a deprecable approach we have used during the Wallet PoC where the presented credential, included in the vp_token array, was enveloped in a VP JWT.
This PR clarifies the methods for presenting individual credentials, referring to their specifications.
however, at this stage, clarifications and examples are provided exclusively for SD-JWT and the section dedicated to the presentation of mdoc cbor is To Be Defined.
To be decided whether to enrich this PR with the mdoc cbor part or whether to include this in future PRs.