Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Wallet Attestation request flow #233

Merged
merged 26 commits into from
Apr 5, 2024

Conversation

grausof
Copy link
Collaborator

@grausof grausof commented Mar 12, 2024

This PR introduces the flow of obtaining the Wallet Attestation using the Key Attestation and Integrity Check systems of Android and iOS through an abstraction called Device Integrity Service. This implementation allows you to securely obtain attestation and verify that the device has not been tampered with as well as ensures that the running application is genuine and the keys used are hardware backed.

This PR resolve:

@grausof grausof requested review from peppelinux and fmarino-ipzs and removed request for peppelinux March 12, 2024 17:57
docs/en/defined-terms.rst Outdated Show resolved Hide resolved
docs/en/defined-terms.rst Outdated Show resolved Hide resolved
docs/en/defined-terms.rst Outdated Show resolved Hide resolved
docs/en/defined-terms.rst Outdated Show resolved Hide resolved
docs/en/defined-terms.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Show resolved Hide resolved
docs/en/wallet-attestation.rst Show resolved Hide resolved
docs/en/wallet-attestation.rst Show resolved Hide resolved
docs/en/wallet-solution.rst Outdated Show resolved Hide resolved
docs/en/defined-terms.rst Show resolved Hide resolved
Copy link
Member

@peppelinux peppelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR requires some changes regarding a the defined terms and the examples about the technologies that the WSCD may use

docs/en/defined-terms.rst Outdated Show resolved Hide resolved
docs/en/defined-terms.rst Outdated Show resolved Hide resolved
docs/en/defined-terms.rst Outdated Show resolved Hide resolved
docs/en/defined-terms.rst Show resolved Hide resolved
Copy link
Member

@peppelinux peppelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost done :-)

docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
grausof and others added 2 commits April 3, 2024 17:14
Co-authored-by: Giuseppe De Marco <[email protected]>
Co-authored-by: Giuseppe De Marco <[email protected]>
@grausof grausof requested a review from peppelinux April 3, 2024 15:16
Copy link
Member

@peppelinux peppelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my review, I suggest adding more details about the types of WSCDs that the wallet solution may implement.

docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
docs/en/wallet-attestation.rst Outdated Show resolved Hide resolved
Co-authored-by: Giuseppe De Marco <[email protected]>
Copy link
Collaborator

@fmarino-ipzs fmarino-ipzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The LoA topic should be further discussed.

docs/en/wallet-solution.rst Outdated Show resolved Hide resolved
Copy link
Member

@peppelinux peppelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

editorial

docs/en/wallet-solution.rst Outdated Show resolved Hide resolved
Co-authored-by: Giuseppe De Marco <[email protected]>
@peppelinux peppelinux merged commit 5c38e12 into versione-corrente Apr 5, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants