Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: removed IDA from vc datamodel #217

Merged
merged 8 commits into from
Feb 29, 2024
Merged

fix!: removed IDA from vc datamodel #217

merged 8 commits into from
Feb 29, 2024

Conversation

fmarino-ipzs
Copy link
Collaborator

@fmarino-ipzs fmarino-ipzs commented Feb 29, 2024 •
edited
Loading

Title

Content

This PR

  • temporarily removes the IDA profile from the data model sd-jwt vc. Information about authentic source verification data is ensured by PR AS metadata != VCI metadata #216 (in that PR the verification field has been added to the Issuer Metadata).
  • introduces the status attestation

Review

  • Ensure your files are written following RST specs (not MD!)
  • Italian version
  • English version
  • Example files
  • Ask for review

@fmarino-ipzs fmarino-ipzs added this to the 0.6.0 milestone Feb 29, 2024
@fmarino-ipzs @peppelinux
Apply suggestions from code review
3fc9e70 
Co-authored-by: Giuseppe De Marco <[email protected]>
@fmarino-ipzs @peppelinux
Apply suggestions from code review
fca242a 
Co-authored-by: Giuseppe De Marco <[email protected]>
@balanza
Copy link
Contributor

balanza commented Feb 29, 2024

It also introduces status attestations

@fmarino-ipzs @peppelinux
Apply suggestions from code review
669b9fc 
Co-authored-by: Giuseppe De Marco <[email protected]>
@peppelinux peppelinux mentioned this pull request Feb 29, 2024
Closed
grausof
grausof approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@grausof grausof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peppelinux peppelinux merged commit 35d7f07 into versione-corrente Feb 29, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grausof grausof grausof approved these changes

@peppelinux peppelinux peppelinux approved these changes

@balanza balanza Awaiting requested review from balanza

Assignees
No one assigned
Labels
breaking change issuance presentation
Projects
EUDI Wallet IT Technical Specifications
Status: Done
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fmarino-ipzs @balanza @grausof @peppelinux