Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Relying Party - discovery_uri, removal of DPoP and random fragment for request and response endpoints #176

Merged
merged 22 commits into from
Jan 17, 2024

Conversation

peppelinux
Copy link
Member

@peppelinux peppelinux commented Dec 12, 2023

this PR

…nt for request and response endpoints - seq diag
@peppelinux
Copy link
Member Author

See also
italia/eudi-wallet-it-python@fc4f7d9

docs/en/relying-party-solution.rst Outdated Show resolved Hide resolved
docs/en/relying-party-solution.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@asharif1990 asharif1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a pass with a request to make some minor editorial changes to the MSC and the text.

docs/en/relying-party-solution.rst Outdated Show resolved Hide resolved
docs/en/relying-party-solution.rst Outdated Show resolved Hide resolved
@peppelinux peppelinux marked this pull request as draft January 6, 2024 16:27
@peppelinux
Copy link
Member Author

two things to be done in this draft before making it a ready-to-be-merged PR:

  1. abandon the discovery_uri and use the extention of the request_uri endpoint with the uri methods param, according to this: https://github.com/openid/OpenID4VP/pull/59/files
  2. abandon the custom url-scheme and use onlt universal links; add also a box with the rationale behind this decision

@peppelinux peppelinux self-assigned this Jan 8, 2024
@peppelinux peppelinux marked this pull request as ready for review January 9, 2024 10:49
Copy link
Collaborator

@fmarino-ipzs fmarino-ipzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made an editorial change in the sequence diagram. I updated the plantuml link as a suggestion but the SVG must be updated accordingly.

docs/en/relying-party-solution.rst Outdated Show resolved Hide resolved
docs/en/relying-party-solution.rst Outdated Show resolved Hide resolved
docs/en/relying-party-solution.rst Outdated Show resolved Hide resolved
peppelinux and others added 5 commits January 10, 2024 14:21
feat: added ISO18013 proximity flow
Remote and Proximity flows are split in two different rst file. Some sphinz build issues are fixed.
@peppelinux
Copy link
Member Author

Guys I merge this PR since it brings many important changes to be aligned, however the discussion on the OpenID4VP flows is still on the way, where discovery_uri (here) would be used instead of the request_uri_method

This means that we'll continue working with openid wg to achieve the definitive approach for that and then we'll open another PR about the presentation flow

@peppelinux peppelinux merged commit b5b612e into versione-corrente Jan 17, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

How the request_uri brings the appropriate entropy
4 participants