Feature zms 2962 extend log table #570
Conversation
| \DateTimeInterface $now, | ||
| $resolveReferences = 0, | ||
| $previousStatus = null, | ||
| ?\BO\Zmsentities\Useraccount $useraccount = null |
There was a problem hiding this comment.
$useraccount should be $userAccount
| $process, | ||
| \BO\Zmsentities\Scope $scope, | ||
| int $waitingNumber, | ||
| ?\BO\Zmsentities\Useraccount $useraccount = null |
There was a problem hiding this comment.
$useraccount should be $userAccount
| Query::writeProcessLog( | ||
| "MTA successful, subject=" . $mimepart->content, | ||
| Query::ACTION_MAIL_FAIL, | ||
| $process |
There was a problem hiding this comment.
Fix the logical error in the condition block
There appears to be a mismatch between the $isError condition and the logged actions. Currently, a success action is logged when there's an error, and vice versa. This needs to be corrected to ensure accurate logging.
Please apply the following changes:
if ($isError) {
Query::writeProcessLog(
"MTA failed, message=" . $mimepart->content,
- Query::ACTION_MAIL_SUCCESS,
+ Query::ACTION_MAIL_FAIL,
$process
);
} else {
Query::writeProcessLog(
"MTA successful, subject=" . $mimepart->content,
- Query::ACTION_MAIL_FAIL,
+ Query::ACTION_MAIL_SUCCESS,
$process
);
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| $process | |
| Query::writeProcessLog( | |
| "MTA failed, message=" . $mimepart->content, | |
| Query::ACTION_MAIL_FAIL, | |
| $process | |
| ); | |
| } else { | |
| Query::writeProcessLog( | |
| "MTA successful, subject=" . $mimepart->content, | |
| Query::ACTION_MAIL_SUCCESS, | |
| $process |
Description
Short description or comments
Reference
Issues #XXX