Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mix 1498 1629 #40

Merged
merged 77 commits into from
Dec 4, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
ba004a1
Add recall time migration01~
ThomasAFink Nov 20, 2023
ce33184
Solution using updateTimestamp
ThomasAFink Nov 20, 2023
5c4a7ec
Format minutes
ThomasAFink Nov 20, 2023
7efcbbb
It actually works lol
ThomasAFink Nov 22, 2023
fdfcb6a
Merge pull request #13 from it-at-m/feature-1629-create-default-calld…
manjencic Nov 23, 2023
dd3ce39
Merge pull request #14 from it-at-m/feature-1629-create-default-calld…
manjencic Nov 23, 2023
80c7945
Merge pull request #15 from it-at-m/feat-1626-dont-send-notifications…
manjencic Nov 23, 2023
e99c762
It works using previous status
ThomasAFink Nov 23, 2023
af98db9
some cleanup
ThomasAFink Nov 24, 2023
38e8a10
more cleanup
ThomasAFink Nov 24, 2023
67b1c77
more cleanup
ThomasAFink Nov 24, 2023
bd2cb50
more cleanup
ThomasAFink Nov 24, 2023
0b33bb6
more cleanup
ThomasAFink Nov 24, 2023
3c57c8b
more cleanup
ThomasAFink Nov 24, 2023
9c74565
What are these changes?
ThomasAFink Nov 24, 2023
f2cb812
Merge branch 'feature-1498_wiederaufruf_erst_nach_5_minuten' into mix…
ThomasAFink Nov 24, 2023
2890290
Fix permissions
ThomasAFink Nov 24, 2023
eff8aac
Fix permissions
ThomasAFink Nov 24, 2023
e48766f
Fix permissions
ThomasAFink Nov 24, 2023
ebd66b3
Fix migrations
ThomasAFink Nov 24, 2023
8fe6915
Merge pull request #18 from it-at-m/feature-zms-1488-show-finished-ap…
manjencic Nov 27, 2023
f914a1d
Make first process not callable when conditions are met
ThomasAFink Nov 27, 2023
b51c88d
Clean up time functions to fix unit tests
ThomasAFink Nov 27, 2023
db1560e
Test permissions
ThomasAFink Nov 27, 2023
daa4930
Fix file permissions
ThomasAFink Nov 27, 2023
5260f32
Fix file permissions
ThomasAFink Nov 27, 2023
30ac68d
Fix file permissions
ThomasAFink Nov 27, 2023
4dff7ec
Fix file permissions
ThomasAFink Nov 27, 2023
c2329cc
Fix file permissions
ThomasAFink Nov 27, 2023
1e825cf
Fix file permissions
ThomasAFink Nov 27, 2023
e6dae67
Fix file permissions
ThomasAFink Nov 27, 2023
5f02654
Revert "Fix file permissions"
ThomasAFink Nov 27, 2023
f9fdbb9
test
tobias74 Nov 27, 2023
1eabf55
Fix file permissions
ThomasAFink Nov 27, 2023
2f0f52e
composer update with roave advisories
tobias74 Nov 27, 2023
9bff568
Fix file permissions
ThomasAFink Nov 27, 2023
db82aaf
Fix file permissions
ThomasAFink Nov 27, 2023
132bd01
intermediate commit
tobias74 Nov 27, 2023
90038a7
remove unused package 'spiral'
tobias74 Nov 27, 2023
05033d1
Merge pull request #20 from tobias74/ZMS-1693-roave-security-advisories
tobias74 Nov 27, 2023
b70d6ae
Merge pull request #22 from it-at-m/test
manjencic Nov 27, 2023
7391608
merge into dev
manjencic Nov 27, 2023
abe36e5
merged dev into mix
ThomasAFink Nov 27, 2023
bfd64fd
Merge pull request #4 from tobias74/zms-1628-make-email-optional
tobias74 Nov 27, 2023
786ac18
Merge pull request #24 from it-at-m/ZMS-1693-roave-security-advisories
tobias74 Nov 27, 2023
d1313ee
merge dev into mix
ThomasAFink Nov 27, 2023
427f1cf
resolve conflicts
manjencic Nov 27, 2023
e6951e9
Merge branch 'dev' of https://github.com/it-at-m/eappointment into dev
manjencic Nov 28, 2023
99bac35
Merge pull request #25 from it-at-m/feature-1631
manjencic Nov 28, 2023
a605b1f
Merge pull request #17 from it-at-m/mix-1498-1629
ThomasAFink Nov 29, 2023
d6f1393
Revert "Mix 1498 1629 into main"
ThomasAFink Nov 29, 2023
d098455
Merge pull request #26 from it-at-m/revert-17-mix-1498-1629
ThomasAFink Nov 29, 2023
20a87a5
Merge dev into mix
ThomasAFink Nov 29, 2023
8f619b9
Merge pull request #27 from it-at-m/dev
ThomasAFink Nov 29, 2023
18ad198
Merge pull request #28 from it-at-m/mix-1498-1629
ThomasAFink Nov 29, 2023
4cd9ade
fix spelling
ThomasAFink Nov 29, 2023
495b43b
Fix wartestatistik
ThomasAFink Nov 30, 2023
e3df73b
Fix Dienstleistungsstatistik
ThomasAFink Nov 30, 2023
0ddcc2f
Merge pull request #29 from it-at-m/bug-1702-1645_wartestatistik-tage…
ThomasAFink Nov 30, 2023
f8c2fcb
feat(ZMS-1633): create two call displays
manjencic Nov 30, 2023
0859a99
feat(ZMS-1633): merge into dev
manjencic Nov 30, 2023
660a3bf
feat(ZMS-1633): fix collection chunk
manjencic Nov 30, 2023
62b2405
Merge pull request #32 from it-at-m/feature-1633-two-displays
manjencic Nov 30, 2023
c260b00
feat(ZMS-1633): fix templates
manjencic Nov 30, 2023
32c19cb
Merge pull request #33 from it-at-m/feature-1633-two-displays
manjencic Nov 30, 2023
5256c36
Fix Spontankunden
ThomasAFink Nov 30, 2023
1a79cb8
Merge pull request #34 from it-at-m/bug-1702-1645_wartestatistik-tage…
ThomasAFink Nov 30, 2023
affa54f
Update WorkstationProcessNext.php
ThomasAFink Nov 30, 2023
bb71716
Merge pull request #35 from it-at-m/feature-1498-wiederaufruf-erst-na…
ThomasAFink Nov 30, 2023
b4319a7
Merge pull request #39 from it-at-m/feature-1498-wiederaufruf-erst-na…
ThomasAFink Dec 4, 2023
f44afbf
feat(ZMS-1223): dont check seat number
manjencic Dec 4, 2023
f51a57b
merge test into mix-1498-1629
ThomasAFink Dec 4, 2023
e8751b1
Merge main into dev
manjencic Dec 4, 2023
0410aa4
Merge pull request #41 from it-at-m/feature-1223-dont-check-seat-number
manjencic Dec 4, 2023
2383042
remove spaces
ThomasAFink Dec 4, 2023
d50c3aa
Merge branch 'dev' into mix-1498-1629
ThomasAFink Dec 4, 2023
518ffe6
Revert "Merge branch 'dev' into mix-1498-1629"
ThomasAFink Dec 4, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zmsadmin/src/Zmsadmin/Application.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class Application extends \BO\Slim\Application

const DEBUG = false;

const TWIG_CACHE = '/cache/';
ThomasAFink marked this conversation as resolved.
Show resolved Hide resolved
const TWIG_CACHE = false;

const TEMPLATE_PATH = ZMS_ADMIN_TEMPLATE_FOLDER;

Expand Down
1 change: 1 addition & 0 deletions zmsadmin/src/Zmsadmin/Helper/GraphDefaults.php
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ public static function getProcess()
id
status
createTimestamp
updateTimestamp
reminderTimestamp
appointments{
date
Expand Down
14 changes: 13 additions & 1 deletion zmsadmin/templates/block/queue/table.twig
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,19 @@
{% endif %}
</td>
<td>Dieser Kunde ist nicht erschienen</td>
<td><a href="#" data-id="{{ item.id }}" class="process-reset">wieder aufnehmen</a></td>
<td>{{ item.customTextfield|decodeEntities|raw }}</td>
{% set currentTime = "now"|date('U') %}
{% set updateTimestamp = item.updateTimestamp|date('U') %}
{% set fiveMinutes = 300 %}

{% if currentTime - updateTimestamp > fiveMinutes %}
<td>
{{ item.updateTimestamp }}
<a href="#" data-id="{{ item.id }}" class="process-reset">wieder aufnehmen</a>
</td>
{% else %}
<td>{{ item.updateTimestamp }}</td>
{% endif %}
</tr>
{% endfor %}
</table>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
ALTER TABLE buerger
ADD COLUMN `recall_time` time DEFAULT NULL;

ALTER TABLE standort
ADD COLUMN `recall_time_limit` INT(5) NOT NULL DEFAULT 5;
7 changes: 5 additions & 2 deletions zmsdb/src/Zmsdb/Query/Process.php
Original file line number Diff line number Diff line change
Expand Up @@ -203,9 +203,10 @@ public function getEntityMapping()
'customTextfield' => 'process.custom_text_field',
'createIP' => 'process.IPAdresse',
'createTimestamp' => 'process.IPTimeStamp',
'updateTimestamp' => 'process.updateTimestamp',
'lastChange' => 'process.updateTimestamp',
'showUpTime' => 'process.showUpTime',
'finishTime' => 'process.finishTime',
'finishTime' => 'process.finishTime',
'status' => $status_expression,
'queue__status' => $status_expression,
'queue__arrivalTime' => self::expression(
Expand Down Expand Up @@ -794,13 +795,15 @@ protected function addProcessingTimeData($process, \DateTimeInterface $dateTime)
{
$data = array();

//print($process->status);
ThomasAFink marked this conversation as resolved.
Show resolved Hide resolved

if ($process->status == 'processing') {
$data['showUpTime'] = $dateTime->format('Y-m-d H:i:s');
}

if ($process->status == 'finished') {
$data['finishTime'] = $dateTime->format('Y-m-d H:i:s');
}
}

$this->addValues($data);
}
Expand Down
8 changes: 4 additions & 4 deletions zmsdb/tests/Zmsdb/IcsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ class IcsTest extends Base
public function testBasic()
{
setlocale(LC_ALL, 'de_DE');
$testTimestamp = 1463062089; // 12.5.2016, 16:08:09 GMT+2:00 DST saved in base64 ics string below
$updateTimestamp = 1463062089; // 12.5.2016, 16:08:09 GMT+2:00 DST saved in base64 ics string below
$process = (new Process())->readEntity(169530, 'b3b0', 3); //process from testDB import
$config = (new Config())->readEntity();

$ics = \BO\Zmsentities\Helper\Messaging::getMailIcs($process, $config, 'appointment', null, $testTimestamp);
$ics = \BO\Zmsentities\Helper\Messaging::getMailIcs($process, $config, 'appointment', null, $updateTimestamp);

$this->assertEntity("\\BO\\Zmsentities\\Ics", $ics);
$this->assertStringContainsString('169530', $ics->getContent());
Expand All @@ -25,11 +25,11 @@ public function testBasic()

public function testDeleteIcs()
{
$testTimestamp = 1463062089; // 12.5.2016, 16:08:09 GMT+2:00 DST saved in base64 ics string below
$updateTimestamp = 1463062089; // 12.5.2016, 16:08:09 GMT+2:00 DST saved in base64 ics string below
$process = (new Process())->readEntity(169530, 'b3b0'); //process from testDB import
$process->status = 'deleted';
$config = (new Config())->readEntity();
$ics = \BO\Zmsentities\Helper\Messaging::getMailIcs($process, $config, 'deleted', null, $testTimestamp);
$ics = \BO\Zmsentities\Helper\Messaging::getMailIcs($process, $config, 'deleted', null, $updateTimestamp);
$this->assertEntity("\\BO\\Zmsentities\\Ics", $ics);
$this->assertStringContainsString('CANCELLED', $ics->getContent());
$this->assertStringContainsString('UID:20160408-169530', $ics->getContent());
Expand Down
4 changes: 4 additions & 0 deletions zmsentities/schema/dereferenced/day.json
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,10 @@
"type": "string",
"description": "unix timestamp og time when process has been finished"
},
"updateTimestamp": {
"type": "string",
"description": "unix timestamp og time when process has been missed"
},
"scope": {
"id": 123,
"hint": "Standort aus Beispiel-Termin",
Expand Down
4 changes: 4 additions & 0 deletions zmsentities/schema/dereferenced/mail.json
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,10 @@
"type": "string",
"description": "unix timestamp og time when process has been finished"
},
"updateTimestamp": {
"type": "string",
"description": "unix timestamp og time when process has been missed"
},
"clients": {
"type": "array",
"items": {
Expand Down
4 changes: 4 additions & 0 deletions zmsentities/schema/dereferenced/notification.json
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,10 @@
"type": "string",
"description": "unix timestamp og time when process has been finished"
},
"updateTimestamp": {
"type": "string",
"description": "unix timestamp og time when process has been missed"
},
"clients": {
"type": "array",
"items": {
Expand Down
5 changes: 5 additions & 0 deletions zmsentities/schema/dereferenced/process.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"createIP": "145.15.3.10",
"createTimestamp": 1447931596,
"lastChange": 1447931596,
"updateTimestamp": 1447931596,
"id": 123456,
"queue": {
"arrivalTime": 1447922893,
Expand Down Expand Up @@ -233,6 +234,10 @@
"type": "string",
"description": "unix timestamp og time when process has been finished"
},
"updateTimestamp": {
"type": "string",
"description": "unix timestamp og time when process has been missed"
},
"queue": {
"type": "object",
"description": "A queue represents a waiting queue for processes\/clients.",
Expand Down
4 changes: 4 additions & 0 deletions zmsentities/schema/dereferenced/workstation.json
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,10 @@
"type": "string",
"description": "unix timestamp og time when process has been finished"
},
"updateTimestamp": {
"type": "string",
"description": "unix timestamp og time when process has been missed"
},
"clients": {
"type": "array",
"items": {
Expand Down
5 changes: 5 additions & 0 deletions zmsentities/schema/process.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"createIP": "145.15.3.10",
"createTimestamp": 1447931596,
"lastChange": 1447931596,
"updateTimestamp": 1447931596,
"id": 123456,
"queue": {
"arrivalTime": 1447922893,
Expand Down Expand Up @@ -316,6 +317,10 @@
"type": "string",
"description": "unix timestamp og time when process has been finished"
},
"updateTimestamp": {
"type": "string",
"description": "unix timestamp og time when process has been missed"
},
"queue": {
"$ref": "queue.json"
},
Expand Down
4 changes: 4 additions & 0 deletions zmsentities/src/Zmsentities/Process.php
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ public function getDefaults()
return [
'amendment' => '',
'customTextfield' => '',
'updateTimestamp' => time(),
'appointments' => new Collection\AppointmentList(),
'apiclient' => new Apiclient(),
'authKey' => '',
Expand Down Expand Up @@ -461,6 +462,7 @@ public function withLessData(array $keepArray = [])
}

unset($entity['createTimestamp']);
unset($entity['updateTimestamp']);
unset($entity['createIP']);

if ($entity->toProperty()->scope->status->isAvailable()) {
Expand Down Expand Up @@ -579,6 +581,7 @@ public function toDerefencedAmendment()
'StandortID' => $this->scope['id'],
'Anmerkung' => $this->amendment,
'IPTimeStamp' => $this->createTimestamp,
'updateTimestamp' => $this->updateTimestamp,
'LastChange' => $lastChange,
),
1
Expand All @@ -594,6 +597,7 @@ public function toDerefencedCustomTextfield()
'StandortID' => $this->scope['id'],
'CustomTextfield' => $this->customTextfield,
'IPTimeStamp' => $this->createTimestamp,
'updateTimestamp' => $this->updateTimestamp,
'LastChange' => $lastChange,
),
1
Expand Down
Loading