chore(#346): rename maven group names digiwf-connector #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darenegade
reviewed
Jul 27, 2023
Comment on lines
+1
to
+23
| name: build services | ||
|
|
||
| on: [ push, pull_request ] | ||
|
|
||
| jobs: | ||
| build-maven: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Set up JDK 11 | ||
| uses: actions/setup-java@v3 | ||
| with: | ||
| java-version: '11' | ||
| distribution: 'adopt' | ||
| server-id: camunda-bpm-nexus-ee | ||
| server-username: CAMUNDA_USER_REF | ||
| server-password: CAMUNDA_TOKEN_REF | ||
|
|
||
| - name: Build with Maven | ||
| run: mvn --batch-mode --update-snapshots --no-transfer-progress verify -f pom-old.xml | ||
| env: | ||
| CAMUNDA_USER_REF: ${{ secrets.CAMUNDA_USER }} | ||
| CAMUNDA_TOKEN_REF: ${{ secrets.CAMUNDA_USER_PASSWORD }} |
There was a problem hiding this comment.
Den Workflow musst du nicht anpassen - Siehe POM Kommentar
darenegade
reviewed
Jul 27, 2023
Comment on lines
34
to
36
| <modules> | ||
| <module>digiwf-engine</module> | ||
| <module>digiwf-connector</module> | ||
| <module>digiwf-schema-registry</module> | ||
| <module>digiwf-task</module> | ||
| <module>digiwf-libs</module> | ||
| <module>digiwf-process</module> | ||
| <module>digiwf-gateway</module> | ||
| <module>digiwf-integrations</module> | ||
| <module>digiwf-coverage</module> | ||
| </modules> |
There was a problem hiding this comment.
Genau dieser Teil muss komplett raus. Das ist die Aggregation und kann eigenständig in einer POM gelöst sein.
Dann hat man zwei weitere POMs, die nur als Parent dienen mit den unterschiedlichen groupIDs, aber alle Module weiterhin in der Aggregation-POM zusammen gebaut über einen Befehl
|
Ich mache den PR nochmal zu und einen neuen auf, das geht einfacher |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Short description or comments
Reference
Issues #346