Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/refactor presigned url usage #1839

Merged
merged 12 commits into from
Jul 12, 2024
Merged

Conversation

simonhir
Copy link
Member

@simonhir simonhir commented Jul 10, 2024

Description

Add support for invocation without presignedUrls input for mail and cosys integration.

Reference

Issues: #1734

Check-List

  • All Acceptance criteria of user story are met
  • JUnit tests are written (60% CodeCov)
  • Documentations external
    and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No waste on Branch left (e.g. console.logs)
  • Board is up-to-date
  • Internal Services / Artifacts updated (Depending on Change -
    See Dependency Graph -> bpm-modeler!93
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained -> digiwf-ops!481

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 85.78947% with 27 lines in your changes missing coverage. Please review.

Project coverage is 47.01%. Comparing base (5926e61) to head (894704b).

Files Patch % Lines
...wf/email/integration/adapter/out/s3/S3Adapter.java 3.84% 25 Missing ⚠️
...integration/domain/model/paths/BasicMailPaths.java 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #1839      +/-   ##
============================================
+ Coverage     46.35%   47.01%   +0.65%     
- Complexity     1033     1060      +27     
============================================
  Files           497      505       +8     
  Lines          7759     7906     +147     
  Branches        468      471       +3     
============================================
+ Hits           3597     3717     +120     
- Misses         4004     4030      +26     
- Partials        158      159       +1     
Flag Coverage Δ
unittests 47.01% <85.78%> (+0.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonhir simonhir marked this pull request as ready for review July 10, 2024 13:09
@lehju lehju self-requested a review July 10, 2024 13:20
@simonhir simonhir merged commit f3b6193 into dev Jul 12, 2024
15 checks passed
@simonhir simonhir deleted the feature/refactor-presigned-url-usage branch July 12, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants