Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1702 Interim solution by documentation in s3 integration readme #1708

Merged

Conversation

boal
Copy link
Contributor

@boal boal commented May 22, 2024

Description

Until an implementation decision for the s3 integration is made regarding the use of pure REST without a message broker, the solution should be documented within the readme file.

Reference

Issues: #1702

Check-List

  • All Acceptance criteria of user story are met

@boal boal changed the title #1702 Interim solution by documentation #1702 Interim solution by documentation in s3 integration May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.73%. Comparing base (fccc8ee) to head (8e83827).

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1708   +/-   ##
=========================================
  Coverage     44.73%   44.73%           
  Complexity     1706     1706           
=========================================
  Files           653      653           
  Lines          9629     9629           
  Branches        477      477           
=========================================
  Hits           4308     4308           
  Misses         5139     5139           
  Partials        182      182           
Flag Coverage Δ
unittests 44.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@boal boal changed the title #1702 Interim solution by documentation in s3 integration #1702 Interim solution by documentation in s3 integration readme May 23, 2024
Copy link
Member

@darenegade darenegade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boal Thanks

@darenegade darenegade merged commit 2abe261 into it-at-m:dev May 23, 2024
8 of 12 checks passed
@boal boal deleted the feature/#1702-interim-solution-by-documentation branch June 10, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants