Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Checklist #1376

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Require Checklist #1376

merged 2 commits into from
Feb 29, 2024

Conversation

darenegade
Copy link
Member

@darenegade darenegade commented Feb 29, 2024

Description

Checklist is mandatory

Reference

no ref

Screenshots (If UI changed)

no ui change

Check-List

  • All Acceptance criteria of user story are met
  • Accessibility was considered and tested (On UI Change)
  • JUnit tests are written (60% CodeCov)
  • Internal Review is maintained
  • Documentations external and internal are completed
  • Smoketest successful (Manual E2E-Test depending on Change)
  • No waste on Branch left (e.g. console.logs)
  • Board is up-to-date
  • Openshift environments are prepared (Secrets, etc.) and release-issue is maintained
  • Test

@darenegade darenegade self-assigned this Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.76%. Comparing base (27034c4) to head (27f27f4).

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #1376   +/-   ##
=========================================
  Coverage     41.76%   41.76%           
  Complexity     1504     1504           
=========================================
  Files           625      625           
  Lines          9092     9092           
  Branches        446      446           
=========================================
  Hits           3797     3797           
  Misses         5146     5146           
  Partials        149      149           
Flag Coverage Δ
unittests 41.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@simonhir simonhir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super Funktion 👍

@darenegade darenegade merged commit 63f201b into dev Feb 29, 2024
10 of 11 checks passed
@darenegade darenegade deleted the chore/require-dependabot branch February 29, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants