Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRPC-WEB is a valid port protocol, but not listed #2986

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Conversation

craigbox
Copy link
Contributor

@craigbox craigbox commented Nov 9, 2023

correctly in the docs.

Adopted from istio/istio.io#10942.

@craigbox craigbox requested a review from a team as a code owner November 9, 2023 01:36
@istio-policy-bot
Copy link

😊 Welcome @craigbox! This is either your first contribution to the Istio api repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 9, 2023
@craigbox craigbox added the release-notes-none Indicates a PR that does not require release notes. label Nov 9, 2023
@istio-testing istio-testing merged commit 446e4a5 into master Nov 10, 2023
9 checks passed
@istio-testing istio-testing deleted the docs-10942 branch November 10, 2023 01:50
@ericvn
Copy link

ericvn commented Nov 13, 2023

/cherry-pick release-1.20

@istio-testing
Copy link
Collaborator

@ericvn: new pull request created: #2989

In response to this:

/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants