-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Documentation CI + General CI Cleanup #7105
base: main
Are you sure you want to change the base?
Conversation
Strangely, the Documentation fails here, but in my fork repo with the same commit it runs without problems: Also, I do not know what this error means: make[1]: *** [CMakeFiles/Makefile2:4155: cpp/pybind/CMakeFiles/python-package.dir/rule] Error 2
make: *** [Makefile:1060: python-package] Error 2 Maybe somebody can restart the Documentation CI job? |
I went through the CI and cleaned up a bit. Centralized versions to requirements*.txtThere was a TODO comment in Updated pip versionPip version used in CI was updated from 23.2.1 to 24.3.1. Removed outdated version pinning of jedi and idnaBoth issues were solved upstream a couple of years ago: Synchronized pyproject.toml with requirements*.txt filesThere were version mismatches between those files. |
Ok, I think I found the issue why the Documentation CI was successful on my fork but failing here: In order to support building on 24.04, probably a docker build should be added for that (future work though). |
This problem right?
I think it is ubuntu-latest on purpose to detect problems with new versions. That's how I understand the comment in the workflow file. |
Yes, that is my thought as well. |
Type
Motivation and Context
Documentation CI is failing due to missing dependency for cmake.
The issue is that the dependency install script assumes Ubuntu 20.04 (Focal) is used and tries to install CMake from the Kitware APT Repository for Focal.
The github runner uses
ubuntu-latest
thought, which is currentlyUbuntu 22.04 (Jammy)(actually just changed to 24.04 which produces more issues).(See edit at bottom for a description of the general CI cleanups)
Checklist:
python util/check_style.py --apply
to apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
Ubuntu 22.04. (Jammy) already comes with cmake 3.22.1, so using the Kitware APT Repository is not neccessary anymore.
This PR removes the explicit cmake update and thereby fixes the Documentation CI.
Also, the Ubuntu version is pinned to 22.04 because github is changing
ubuntu-latest
to 24.04.Edit:
I went through the CI and cleaned up a bit.
If this is too much change, feel free to tell me, so I can revert to just add the documentation CI fix.
Centralized versions to requirements*.txt
There was a TODO comment in
util/ci_utils.sh
:# TODO: modify other locations to use requirements.txt
So, I went ahead and centralized pip package versions to requirements files where it was possible.
Updated pip version
Pip version used in CI was updated from 23.2.1 to 24.3.1.
Removed outdated version pinning of jedi and idna
Both issues were solved upstream a couple of years ago:
JEDI_VER: "0.17.2"
ipython/ipython#12740IDNA_VER: "2.8"
# psf/requests#5710Synchronized pyproject.toml with requirements*.txt files
There were version mismatches between those files.