Add some helper functions for common usage #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @viraptor, I'd prefer if those helpers were methods on a trait that is impl'd for QueryMap. |
| /// ``` | ||
| pub fn require_query_params(req: &mut Request) -> IronResult<QueryMap> { | ||
| req.get::<UrlEncodedQuery>() | ||
| .map_err(|err| IronError::new(err, status::BadRequest)) |
There was a problem hiding this comment.
I think we might be able to avoid these extra functions if we impl Into<IronError> for our own error types?
There was a problem hiding this comment.
Generally speaking I think it's wrong to do so - you want to specify an intelligent and semantic response when there is an error, not just toss 400 at everything.
There was a problem hiding this comment.
The point of those helpers is IMO that I don't care about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpers give one-line options for the typical use case: parse the parameters or 400, get required parameter or 400. No existing functionality is changed.
doctest are disabled in Cargo.toml to allow partial examples in the docs.