feat: extension background storage #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionutanin
added
area: background
github-actions
bot
removed
the
area: popup
ionutanin
changed the title
){kind=icon}
){kind=icon}
){kind=icon}
){kind=icon}
dianafulga
reviewed
Feb 14, 2024
src/providers/popup-context.tsx
Outdated
| @@ -27,6 +29,17 @@ export const PopupContext = createContext<PopupContextValue>({ | |||
| export const PopupProvider: React.FC<IProps> = ({ children }) => { | |||
| const [data, setData] = useState<TPopupContext>(defaultData) | |||
|
|
|||
| const getStorageData = async () => await sendMessage({ type: 'GET_STORAGE_DATA' }) | |||
There was a problem hiding this comment.
there are no dependencies, so it can be moved outside the component, maybe a utils file associated with the popup-context provider (maybe group under a folder)
dianafulga
reviewed
Feb 14, 2024
src/background/Background.ts
Outdated
| ] | ||
| private subscriptions: any = [] | ||
| // TO DO: remove these from background into storage or state & use injection | ||
| grantFlow: PaymentFlowService | null = null | ||
| spentAmount: number = 0 | ||
| paymentStarted = false | ||
|
|
||
| constructor() {} | ||
| constructor({ storageService }: any) { | ||
| storageService |
There was a problem hiding this comment.
initialisation of data should be done when create a new instance of storage, because it's a singleton
dianafulga
reviewed
Feb 14, 2024
| import Background from '@/background/Background' | ||
|
|
||
| const getStorageData = async (background: Background) => { | ||
| console.log('getStorageData background', background) |
There was a problem hiding this comment.
I get this is a dummy example, but to show case the usage, you can invoke the background.storageService and return the result
dianafulga
previously approved these changes
Feb 14, 2024
github-actions
bot
added
the
area: popup
dianafulga
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #58
Context