Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ConnectWalletForm): let retry key auto-add on some errors #642

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Oct 3, 2024

Support retry add-key on retry-able errors, such as timed out waiting for login, wrong account was logged in etc.

Also add a cause property on ErrorWithKeyLike.

Part of #613

@github-actions github-actions bot added area: background Improvements or additions to extension background script area: popup Improvements or additions to extension popup labels Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

Extension builds preview

Name Link
Latest commit 28008b6
Latest job logs Run #11179472766
BadgeDownload
BadgeDownload

@sidvishnoi
Copy link
Member Author

On popup re-open After clicking "why?" in error
image image

Base automatically changed from preserve-error-key to main October 4, 2024 11:54
@sidvishnoi sidvishnoi merged commit ef93316 into main Oct 4, 2024
9 checks passed
@sidvishnoi sidvishnoi deleted the key-retry branch October 4, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: background Improvements or additions to extension background script area: popup Improvements or additions to extension popup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants