feat(ConnectWalletForm): ask consent for automatic key addition #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: background
Extension builds preview
|
){kind=icon}
){kind=icon}
sidvishnoi
force-pushed
the
auto-key-consent
branch
from
47a3974
to
ef86b18
Compare
sidvishnoi
force-pushed
the
auto-key-consent
branch
from
ecdf16c
to
fe6d3b4
Compare
|
@sidvishnoi Looks good. My only comment is if we can centre the message and buttons in the pop up |
|
Final: @RabebOthmani 
|
| <AutoKeyAddConsent | ||
| onAccept={() => { | ||
| autoKeyAddConsent.current = true; | ||
| // saveValue('autoKeyAddConsent', true); |
There was a problem hiding this comment.
Probably related to my comment above - saving this preference.
There was a problem hiding this comment.
Yeah, I'm not sure if we want to save, but I kept the code here in case we decide to.
Or, maybe we can ask for consent once per wallet address? Like we'll store the wallet address instead of true there.
If it's false, we most likely want to ask again, as that's a happier path for user (in case they find adding key manually is too much after seeing that input).
raducristianpopa
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes proposed in this pull request
Screencast.from.02-10-24.09.22.43.PM.IST.webm