Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(background/Heartbeat): use alarm instead of storage.set #495

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Aug 8, 2024

Context

Closes #492
Pair programmed with @raducristianpopa and @sidvishnoi

Changes proposed in this pull request

@github-actions github-actions bot added the area: background Improvements or additions to extension background script label Aug 8, 2024
@raducristianpopa
Copy link
Member

raducristianpopa commented Aug 8, 2024

Extension builds preview

Name Link
Latest commit 0f2ada2
Latest job logs Run #10299454799
BadgeDownload
BadgeDownload

@sidvishnoi sidvishnoi changed the title fix(background/Heartbeat): use alarm instead of storage.set fix(background/Heartbeat): use alarm instead of storage.set Aug 8, 2024
@sidvishnoi sidvishnoi marked this pull request as ready for review August 8, 2024 09:43
Copy link
Member

@raducristianpopa raducristianpopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done during pair-programming.

@sidvishnoi sidvishnoi merged commit 8d47b3e into main Aug 8, 2024
8 checks passed
@sidvishnoi sidvishnoi deleted the heartbeat-with-alarm branch August 8, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: background Improvements or additions to extension background script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background script exits in Firefox after a while
2 participants