-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(popup): add ouf of funds and add funds screens #439
Conversation
Extension builds preview
|
if (location.pathname.includes('/s/')) { | ||
return ( | ||
<Link to={location.pathname.split('/s/')[0]}> | ||
<ArrowBack className="h-6" /> | ||
</Link> | ||
) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Demo (to show what texts are shown where and the interactions) Screencast.from.22-07-24.08.05.45.PM.IST.webm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, as agreed in the comments section
{ | ||
path: ROUTES_PATH.OUT_OF_FUNDS_ADD_FUNDS, | ||
lazy: () => import('./pages/OutOfFunds_AddFunds') | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good approach. Let's avoid having other folders in pages
. For the future, defining sub-routes should happen like this.
Context
Changes proposed in this pull request
/s/
in URL (s for screen or sub-page). It allows going back to parent - path before/s/
.