feat: use new icons and alert behavior #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area: background
sidvishnoi
changed the title
Extension builds preview
|
){kind=icon}
){kind=icon}
Closed
|
Will use new icons and update logic when to show each icon (similar to one in this PR, but more icons). See #373 |
sidvishnoi
force-pushed
the
icon-if-disconnected
branch
from
48e4c09
to
986c6bf
Compare
sidvishnoi
changed the title
|
Preview I still think design-wise we're not taking all the available space. But the green/orange/red icons look nice. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
raducristianpopa
approved these changes
Jul 23, 2024
|
As a side note, sometimes on non monetized websites the default icon is displayed instead of the |
|
That's something I saw too, and will handle with TabState changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #373