Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove connections endpoint from resource spec #292

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

omertoast
Copy link
Member

@omertoast omertoast commented Sep 21, 2023

Changes proposed in this pull request

  • remove connections endpoint from the spec
  • remove connections route and associated functionality

Context

@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2023

🦋 Changeset detected

Latest commit: 6614bf3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@interledger/open-payments Minor
@interledger/openapi Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@njlie njlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omertoast Looks like tests still need to be updated, seems to be failing because the /connections/{id} route is still in tests and it doesn't exist anymore.

@njlie
Copy link
Contributor

njlie commented Sep 21, 2023

⚠️ No Changeset found

Latest commit: 6c4a709

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets
Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@omertoast before you merge this in, can you add a changeset as instructed in comment from this bot?

@njlie
Copy link
Contributor

njlie commented Sep 21, 2023

This is going to supersede some changes from #284.

@omertoast omertoast merged commit 2ea12f0 into main Sep 21, 2023
6 checks passed
@omertoast omertoast deleted the omr/rm-connections-endpoint branch September 21, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants