Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] TEST: Run all tests through pytest #2090

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

david-cortes-intel
Copy link
Contributor

Description

Currently, unit tests execute through a mixture of built-in unittest and pytest.

From the commit history, it looks like initial tests were added using python's built-in unittest framework, and then subsequent tests were introduced using pytest.

Compared to unittest, pytest has a much nicer output format, offers many options for how to execute tests and how to see their outputs, and has plugins that allow it do extra things which the built-in cannot when desired (e.g. JSON outputs, test coverage reports, etc.).

This PR switches the automated scripts to execute all of the tests using pytest. This doesn't change what tests were executed - just uses pytest as the runner.

One challenge here is how each of these interprets the path from where modules are imported - here I'm trying to control these with the PYTHONPATH variable when pytest is called within shell scripts, but don't know if this will work out for all the variants under which tests are executed.


Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@david-cortes-intel david-cortes-intel added the testing Tests for sklearnex/daal4py/onedal4py & patching sklearn label Oct 7, 2024
@david-cortes-intel david-cortes-intel marked this pull request as draft October 7, 2024 15:28
@david-cortes-intel
Copy link
Contributor Author

@Alexsandruss Would you perhaps have any pointers about why the failing CI job here:
https://github.com/intel/scikit-learn-intelex/actions/runs/11218859163/job/31183555329?pr=2090

.. might be failing to import daal4py._daal4py in the new pytest call that I added, while it succeeds in the other calls?

@icfaust
Copy link
Contributor

icfaust commented Oct 7, 2024

I've had to fight against pytest's package discovery recently and had to use --rootdir to get things to work properly (https://github.com/intel/scikit-learn-intelex/blob/main/.ci/scripts/run_sklearn_tests.py#L47). Maybe that could help you? I believe your daal4py._daal4py error is coming from the $PYTHONPATH which is using the repo daal4py folder to find daal4py instead of the installed site-packages daal4py, because it can't find the compiled _daal4py.so file there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Tests for sklearnex/daal4py/onedal4py & patching sklearn
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants