MAINT: utility module for Intel data parallel libs; import checks in one place #1936
Conversation
|
/intelci: run |
| def is_dpctl_available(targets=None): | ||
| try: | ||
| def is_dpctl_device_available(targets): | ||
| if dpctl_available: |
There was a problem hiding this comment.
if dpctl_available check can be made an import-time check, rather than runtime.
rename the module for dp utilities update dpnp/dpctl checkers reusing daal4py sklearn_check_version
|
/intelci: run |
samir-nasibli
changed the title
|
/intelci: run |
|
/intelci: run |
| from daal4py.sklearn._utils import _package_check_version | ||
|
|
||
|
|
||
| def is_dpctl_available(version=None): |
There was a problem hiding this comment.
These functions need caching just in case they will be used more extensively in future.
There was a problem hiding this comment.
What does dpep mean? I believe it is confusing name for helper file.
There was a problem hiding this comment.
https://github.com/IntelPython/DPEP
https://intelpython.github.io/DPEP/main/
Do you want me provide links in the docs of the module or just rename?
There was a problem hiding this comment.
I have provided small description in the top of the module
There was a problem hiding this comment.
data_parallel_extensions_helper / data_parallel_ext_helper would be better.
Description
These changes centralized data parallel libs checks, such as DPCtl and DPNP availability. (Also discussed on #1861 (comment))
Proposed changes:
is_dpctl_available/is_dpnp_availbletools for checking the specific dpctl, dpnp versionsis_dpctl_availablefromonedal.tests.utils._device_selectionmodule tois_dpctl_device_available. This tool is used insklearnex/onedaltests where it is needed to check required device(s) availability viadpctl.Non prior. Should be integrated after main is unfreeze.